Skip to content

[RyuJit/WASM] Crossgen2 integration and further factoring #121563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[RyuJit/WASM] Crossgen2 integration and further factoring #121563

wants to merge 7 commits into from
+495 −120

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Nov 12, 2025 •
edited
Loading

This allows:

int add(int a, int b) => a + b;

to run until the NYI in codegen.

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 12, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 12, 2025
This was referenced Nov 13, 2025
Open
Open
Open
Open
Open
Open
This was referenced Nov 13, 2025
Open
Open
@adamperlin
Copy link
Contributor

adamperlin commented Nov 13, 2025

@SingleAccretion I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Nov 13, 2025

I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

Sure!

(But do be prepared for them to perhaps change a bit in the course of the review.)

@adamperlin
Copy link
Contributor

adamperlin commented Nov 13, 2025 •
edited
Loading

I am starting work on the R2R object writer. Is it alright if I copy the crossgen2 integration bits from this PR for that purpose?

Sure!

(But do be prepared for them to perhaps change a bit in the course of the review.)

Ok, that sounds good! I will be prepared that they may change and I'll check back during review!

@SingleAccretion SingleAccretion marked this pull request as ready for review November 15, 2025 01:07
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Nov 15, 2025

@dotnet/jit-contrib

kg
kg reviewed Nov 15, 2025
View reviewed changes
jkotas
jkotas reviewed Nov 15, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Nov 15, 2025
Open
@am11 am11 added the arch-wasm WebAssembly architecture label Nov 15, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Nov 15, 2025

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Nov 16, 2025
Open
3 tasks
AndyAyersMS
AndyAyersMS reviewed Nov 17, 2025
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JIT side of this looks good to me.

@kg any other comments?

kg
kg reviewed Nov 19, 2025
View reviewed changes
kg
kg reviewed Nov 19, 2025
View reviewed changes
@kg
Copy link
Member

kg commented Nov 19, 2025

The JIT side of this looks good to me.

@kg any other comments?

This LGTM as well! Thanks for all the hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kg kg kg left review comments

@jkotas jkotas jkotas left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS left review comments

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SingleAccretion @adamperlin @kg @am11 @jkotas @AndyAyersMS